Skip to content

Conversation

LeSeulArtichaut
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut commented Mar 8, 2021

With the ongoing changes to the THIR (rust-lang/rust#82495, but project-thir-unsafeck in general), it might deserve its own chapter. Here's a stub to begin with.

Helps with rust-lang/project-thir-unsafeck#6, blocked on rust-lang/rust#82495.
Closes #1075.

@LeSeulArtichaut LeSeulArtichaut added the S-blocked Status: this PR is blocked waiting for something label Mar 8, 2021
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@camelid
Copy link
Member

camelid commented Mar 9, 2021

By the way, should this close #1075 or is there more to do?

@LeSeulArtichaut
Copy link
Contributor Author

I think this can close #1075

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jyn514 jyn514 merged commit bfe8e98 into rust-lang:master Mar 10, 2021
@LeSeulArtichaut
Copy link
Contributor Author

rust-lang/rust#82495 hasn't been merged yet (there is a test failure that magically appeared out of nowhere 😕)

@jyn514
Copy link
Member

jyn514 commented Mar 10, 2021

Oh oops - do you want me to revert the change? It sounds like 82495 will be merged shortly so I think it's ok for the docs to be out of sync temporarily.

@LeSeulArtichaut
Copy link
Contributor Author

Let's see. The PR was retried, so if it fails again I'll file a revert

@LeSeulArtichaut
Copy link
Contributor Author

#82495 has been merged now, so this is sorted out

@LeSeulArtichaut LeSeulArtichaut deleted the eager-thir branch March 11, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: this PR is blocked waiting for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation about THIR
3 participants